diff --git a/src/crypto.rs b/src/crypto.rs index bfbd2f4..96f2774 100644 --- a/src/crypto.rs +++ b/src/crypto.rs @@ -73,14 +73,7 @@ fn sign_ecdsa(alg: &'static signature::EcdsaSigningAlgorithm, key: &[u8], signin /// The actual RSA signing + encoding /// Taken from Ring doc https://briansmith.org/rustdoc/ring/signature/index.html -fn sign_rsa(alg: Algorithm, key: &[u8], signing_input: &str) -> Result { - let ring_alg = match alg { - Algorithm::RS256 => &signature::RSA_PKCS1_SHA256, - Algorithm::RS384 => &signature::RSA_PKCS1_SHA384, - Algorithm::RS512 => &signature::RSA_PKCS1_SHA512, - _ => unreachable!(), - }; - +fn sign_rsa(alg: &'static signature::RsaEncoding, key: &[u8], signing_input: &str) -> Result { let key_pair = Arc::new( signature::RsaKeyPair::from_der(untrusted::Input::from(key)) .map_err(|_| ErrorKind::InvalidRsaKey)?, @@ -88,7 +81,7 @@ fn sign_rsa(alg: Algorithm, key: &[u8], signing_input: &str) -> Result { let mut signature = vec![0; key_pair.public_modulus_len()]; let rng = rand::SystemRandom::new(); key_pair - .sign(ring_alg, &rng, signing_input.as_bytes(), &mut signature) + .sign(alg, &rng, signing_input.as_bytes(), &mut signature) .map_err(|_| ErrorKind::InvalidRsaKey)?; Ok(base64::encode_config::<[u8]>(&signature, base64::URL_SAFE_NO_PAD)) @@ -107,15 +100,15 @@ pub fn sign(signing_input: &str, key: &[u8], algorithm: Algorithm) -> Result sign_ecdsa(&signature::ECDSA_P256_SHA256_FIXED_SIGNING, key, signing_input), Algorithm::ES384 => sign_ecdsa(&signature::ECDSA_P384_SHA384_FIXED_SIGNING, key, signing_input), - Algorithm::RS256 | Algorithm::RS384 | Algorithm::RS512 => { - sign_rsa(algorithm, key, signing_input) - } + Algorithm::RS256 => sign_rsa(&signature::RSA_PKCS1_SHA256, key, signing_input), + Algorithm::RS384 => sign_rsa(&signature::RSA_PKCS1_SHA384, key, signing_input), + Algorithm::RS512 => sign_rsa(&signature::RSA_PKCS1_SHA512, key, signing_input), } } -/// See Ring RSA docs for more details -fn verify_rsa( - alg: &signature::RsaParameters, +/// See Ring docs for more details +fn verify_ring( + alg: &dyn signature::VerificationAlgorithm, signature: &str, signing_input: &str, key: &[u8], @@ -150,17 +143,20 @@ pub fn verify( let signed = sign(signing_input, key, algorithm)?; Ok(verify_slices_are_equal(signature.as_ref(), signed.as_ref()).is_ok()) } - Algorithm::ES256 | Algorithm::ES384 => { - unimplemented!() + Algorithm::ES256 => { + verify_ring(&signature::ECDSA_P256_SHA256_FIXED, signature, signing_input, key) + } + Algorithm::ES384 => { + verify_ring(&signature::ECDSA_P384_SHA384_FIXED, signature, signing_input, key) } Algorithm::RS256 => { - verify_rsa(&signature::RSA_PKCS1_2048_8192_SHA256, signature, signing_input, key) + verify_ring(&signature::RSA_PKCS1_2048_8192_SHA256, signature, signing_input, key) } Algorithm::RS384 => { - verify_rsa(&signature::RSA_PKCS1_2048_8192_SHA384, signature, signing_input, key) + verify_ring(&signature::RSA_PKCS1_2048_8192_SHA384, signature, signing_input, key) } Algorithm::RS512 => { - verify_rsa(&signature::RSA_PKCS1_2048_8192_SHA512, signature, signing_input, key) + verify_ring(&signature::RSA_PKCS1_2048_8192_SHA512, signature, signing_input, key) } } } diff --git a/tests/ecdsa.rs b/tests/ecdsa.rs new file mode 100644 index 0000000..72f13df --- /dev/null +++ b/tests/ecdsa.rs @@ -0,0 +1,38 @@ +extern crate jsonwebtoken; +#[macro_use] +extern crate serde_derive; +extern crate chrono; + +use chrono::Utc; +use jsonwebtoken::{decode, encode, sign, verify, Algorithm, Header, Validation}; + +#[derive(Debug, PartialEq, Clone, Serialize, Deserialize)] +struct Claims { + sub: String, + company: String, + exp: i64, +} + +#[test] +fn round_trip_sign_verification() { + let privkey = include_bytes!("private_ecdsa_key.pk8"); + let encrypted = sign("hello world", privkey, Algorithm::ES256).unwrap(); + let pubkey = include_bytes!("public_ecdsa_key.pk8"); + let is_valid = verify(&encrypted, "hello world", pubkey, Algorithm::ES256).unwrap(); + assert!(is_valid); +} + +#[test] +fn round_trip_claim() { + let my_claims = Claims { + sub: "b@b.com".to_string(), + company: "ACME".to_string(), + exp: Utc::now().timestamp() + 10000, + }; + let privkey = include_bytes!("private_ecdsa_key.pk8"); + let token = encode(&Header::new(Algorithm::ES256), &my_claims, privkey).unwrap(); + let pubkey = include_bytes!("public_ecdsa_key.pk8"); + let token_data = decode::(&token, pubkey, &Validation::new(Algorithm::ES256)).unwrap(); + assert_eq!(my_claims, token_data.claims); + assert!(token_data.header.kid.is_none()); +} diff --git a/tests/private_ecdsa_key.pk8 b/tests/private_ecdsa_key.pk8 new file mode 100644 index 0000000..f838b04 Binary files /dev/null and b/tests/private_ecdsa_key.pk8 differ diff --git a/tests/public_ecdsa_key.pk8 b/tests/public_ecdsa_key.pk8 new file mode 100644 index 0000000..188c9d8 --- /dev/null +++ b/tests/public_ecdsa_key.pk8 @@ -0,0 +1 @@ +ò@O%I_!IAM Ly5+\Iw[ a ԫxG2GU \ No newline at end of file