From 9e6e0b1e6f807b836805cfcf1b8f10d3a0aacb70 Mon Sep 17 00:00:00 2001 From: Wilson Lin Date: Wed, 6 Jan 2021 18:02:00 +1100 Subject: [PATCH] Fix missing library linking in Node.js macOS version --- nodejs/binding.c | 5 +++-- nodejs/binding.gyp | 5 +++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/nodejs/binding.c b/nodejs/binding.c index 92ee095..33cf264 100644 --- a/nodejs/binding.c +++ b/nodejs/binding.c @@ -1,4 +1,5 @@ #include +#include #include #include @@ -107,6 +108,7 @@ napi_value node_method_create_configuration(napi_env env, napi_callback_info inf napi_value node_method_minify_in_place(napi_env env, napi_callback_info info) { napi_value undefined = get_undefined(env); + napi_value min_buf_rv = undefined; bool buffer_arg_ref_set = false; napi_ref buffer_arg_ref; @@ -123,7 +125,6 @@ napi_value node_method_minify_in_place(napi_env env, napi_callback_info info) { assert_ok(napi_throw_error(env, NULL, "Failed to get callback info")); goto rollback; } - napi_value min_buf_rv = undefined; napi_value buffer_arg = argv[0]; napi_value js_cfg_arg = argv[1]; @@ -185,6 +186,7 @@ cleanup: napi_value node_method_minify(napi_env env, napi_callback_info info) { napi_value undefined = get_undefined(env); + napi_value min_buf_rv = undefined; void* src_data_copy = NULL; ffi_error const* min_err = NULL; @@ -199,7 +201,6 @@ napi_value node_method_minify(napi_env env, napi_callback_info info) { assert_ok(napi_throw_error(env, NULL, "Failed to get callback info")); goto rollback; } - napi_value min_buf_rv = undefined; napi_value src_arg = argv[0]; napi_value js_cfg_arg = argv[1]; diff --git a/nodejs/binding.gyp b/nodejs/binding.gyp index ce188a0..d6b50a1 100644 --- a/nodejs/binding.gyp +++ b/nodejs/binding.gyp @@ -9,6 +9,11 @@ "native/target/release/", ], "conditions": [ + ["OS=='mac'", { + "libraries": [ + "Security.framework", + ], + }], ["OS!='win'", { "actions": [ {