Avoid mem::uninitialized in generic context as it is unsound with e.g. bool
This commit is contained in:
parent
58ce05ff9a
commit
6d17a383df
16
src/util.rs
16
src/util.rs
|
@ -104,20 +104,26 @@ where
|
||||||
F: Fn(*mut ffi::lua_State) -> R,
|
F: Fn(*mut ffi::lua_State) -> R,
|
||||||
R: Copy,
|
R: Copy,
|
||||||
{
|
{
|
||||||
struct Params<F, R> {
|
union URes<R: Copy> {
|
||||||
|
uninit: (),
|
||||||
|
init: R,
|
||||||
|
}
|
||||||
|
|
||||||
|
struct Params<F, R: Copy> {
|
||||||
function: F,
|
function: F,
|
||||||
result: R,
|
result: URes<R>,
|
||||||
nresults: c_int,
|
nresults: c_int,
|
||||||
}
|
}
|
||||||
|
|
||||||
unsafe extern "C" fn do_call<F, R>(state: *mut ffi::lua_State) -> c_int
|
unsafe extern "C" fn do_call<F, R>(state: *mut ffi::lua_State) -> c_int
|
||||||
where
|
where
|
||||||
|
R: Copy,
|
||||||
F: Fn(*mut ffi::lua_State) -> R,
|
F: Fn(*mut ffi::lua_State) -> R,
|
||||||
{
|
{
|
||||||
let params = ffi::lua_touserdata(state, -1) as *mut Params<F, R>;
|
let params = ffi::lua_touserdata(state, -1) as *mut Params<F, R>;
|
||||||
ffi::lua_pop(state, 1);
|
ffi::lua_pop(state, 1);
|
||||||
|
|
||||||
(*params).result = ((*params).function)(state);
|
(*params).result.init = ((*params).function)(state);
|
||||||
|
|
||||||
if (*params).nresults == ffi::LUA_MULTRET {
|
if (*params).nresults == ffi::LUA_MULTRET {
|
||||||
ffi::lua_gettop(state)
|
ffi::lua_gettop(state)
|
||||||
|
@ -136,7 +142,7 @@ where
|
||||||
|
|
||||||
let mut params = Params {
|
let mut params = Params {
|
||||||
function: f,
|
function: f,
|
||||||
result: mem::uninitialized(),
|
result: URes { uninit: () },
|
||||||
nresults,
|
nresults,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
@ -147,7 +153,7 @@ where
|
||||||
if ret == ffi::LUA_OK {
|
if ret == ffi::LUA_OK {
|
||||||
// LUA_OK is only returned when the do_call function has completed successfully, so
|
// LUA_OK is only returned when the do_call function has completed successfully, so
|
||||||
// params.result is definitely initialized.
|
// params.result is definitely initialized.
|
||||||
Ok(params.result)
|
Ok(params.result.init)
|
||||||
} else {
|
} else {
|
||||||
Err(pop_error(state, ret))
|
Err(pop_error(state, ret))
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue