From e096729759f030beb03dc4b8c037e276cf7b9268 Mon Sep 17 00:00:00 2001 From: Pauan Date: Fri, 30 Apr 2021 00:50:26 +0200 Subject: [PATCH] Minor improvement --- src/operations.rs | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/operations.rs b/src/operations.rs index 911f629..10fba23 100644 --- a/src/operations.rs +++ b/src/operations.rs @@ -111,28 +111,26 @@ pub(crate) fn insert_child_signal(element: Node, callbacks: &mut Callbacks, s } // TODO verify that this will drop `child` - fn after_remove(&mut self, element: &Node, mut child: Option) { + fn after_remove(&mut self, element: &Node, child: Option) { if let Some(old_child) = self.child.take() { bindings::remove_child(&element, &old_child.element); old_child.callbacks.discard(); } - if let Some(ref mut new_child) = child { + self.child = child; + + if let Some(new_child) = &mut self.child { bindings::append_child(&element, &new_child.element); after_insert(self.is_inserted, &mut new_child.callbacks); } - - self.child = child; } fn on_remove(&mut self) { if let Some(old_child) = self.child.take() { old_child.callbacks.discard(); } - - self.child = None; } }