From 85c1014f862978a618794d10ab48698cd6ce2d7d Mon Sep 17 00:00:00 2001 From: Terminator Date: Sat, 10 Oct 2020 04:36:55 +0200 Subject: [PATCH] Don't consume self when writing packet to a writer. Mutability is not affected (#375) * Minor change: Don't consume self when writing packet to a writer. Mutability is not affected. * Further decrease packet write requirements Co-authored-by: Terminator --- protocol/src/protocol/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/protocol/src/protocol/mod.rs b/protocol/src/protocol/mod.rs index cbe8070..0dde0ca 100644 --- a/protocol/src/protocol/mod.rs +++ b/protocol/src/protocol/mod.rs @@ -119,7 +119,7 @@ macro_rules! state_packets { packet::versions::translate_internal_packet_id_for_version(version, State::$stateName, Direction::$dirName, internal_ids::$name, false) } - fn write(self, buf: &mut W) -> Result<(), Error> { + fn write(&self, buf: &mut W) -> Result<(), Error> { $( if true $(&& ($cond(&self)))* { self.$field.write_to(buf)?; @@ -1387,5 +1387,5 @@ impl Clone for Conn { pub trait PacketType { fn packet_id(&self, protocol_version: i32) -> i32; - fn write(self, buf: &mut W) -> Result<(), Error>; + fn write(&self, buf: &mut W) -> Result<(), Error>; }