From 54581b9a7e4c55fc04bd96e7d98e3180ac2298d8 Mon Sep 17 00:00:00 2001 From: liach <7806504+liach@users.noreply.github.com> Date: Mon, 3 Aug 2020 06:39:31 -0500 Subject: [PATCH] Move nbt ops to nbt package (#1651) Fixes #1649 Signed-off-by: liach Co-authored-by: liach --- .../net/minecraft/datafixer/NbtOps.mapping | 4 ---- mappings/net/minecraft/nbt/NbtOps.mapping | 21 +++++++++++++++++++ 2 files changed, 21 insertions(+), 4 deletions(-) delete mode 100644 mappings/net/minecraft/datafixer/NbtOps.mapping create mode 100644 mappings/net/minecraft/nbt/NbtOps.mapping diff --git a/mappings/net/minecraft/datafixer/NbtOps.mapping b/mappings/net/minecraft/datafixer/NbtOps.mapping deleted file mode 100644 index f49219723c..0000000000 --- a/mappings/net/minecraft/datafixer/NbtOps.mapping +++ /dev/null @@ -1,4 +0,0 @@ -CLASS net/minecraft/class_2509 net/minecraft/datafixer/NbtOps - COMMENT Used to represent a Minecraft NBT as a {@link com.mojang.datafixers.Dynamic} for DataFixerUpper. - FIELD field_11560 INSTANCE Lnet/minecraft/class_2509; - CLASS class_5320 MapBuilder diff --git a/mappings/net/minecraft/nbt/NbtOps.mapping b/mappings/net/minecraft/nbt/NbtOps.mapping new file mode 100644 index 0000000000..acaaf9b262 --- /dev/null +++ b/mappings/net/minecraft/nbt/NbtOps.mapping @@ -0,0 +1,21 @@ +CLASS net/minecraft/class_2509 net/minecraft/nbt/NbtOps + COMMENT Used to handle Minecraft NBTs within {@link com.mojang.serialization.Dynamic + COMMENT dynamics} for DataFixerUpper, allowing generalized serialization logic + COMMENT shared across different type of data structures. Use {@link NbtOps#INSTANCE} + COMMENT for the ops singleton. + COMMENT + COMMENT

For instance, dimension data may be stored as JSON in data packs, but + COMMENT they will be transported in packets as NBT. DataFixerUpper allows + COMMENT generalizing the dimension serialization logic to prevent duplicate code, + COMMENT where the NBT ops allow the DataFixerUpper dimension serialization logic + COMMENT to interact with Minecraft NBTs.

+ COMMENT + COMMENT @see NbtOps#INSTANCE + FIELD field_11560 INSTANCE Lnet/minecraft/class_2509; + COMMENT An singleton of the NBT dynamic ops. + COMMENT + COMMENT

This ops does not compress maps (replace field name to value pairs + COMMENT with an ordered list of values in serialization). In fact, since + COMMENT Minecraft NBT lists can only contain elements of the same type, this op + COMMENT cannot compress maps.

+ CLASS class_5320 MapBuilder