Refactored some cursed height limit view names (#2027)

* Refactored some cursed height limit view names

They were either confusing or plainly wrong

Fixed a few javadoc problems

Signed-off-by: liach <liach@users.noreply.github.com>

* embellish javadoc

* Update mappings/net/minecraft/world/HeightLimitView.mapping

* Update mappings/net/minecraft/world/HeightLimitView.mapping

Co-authored-by: enbrain <69905075+enbrain@users.noreply.github.com>

* height is a better name

Signed-off-by: liach <liach@users.noreply.github.com>

* Update mappings/net/minecraft/world/HeightLimitView.mapping

Co-authored-by: YanisBft <doublecraft.official@gmail.com>

Co-authored-by: liach <liach@users.noreply.github.com>
Co-authored-by: enbrain <69905075+enbrain@users.noreply.github.com>
Co-authored-by: YanisBft <doublecraft.official@gmail.com>
This commit is contained in:
liach 2021-02-07 07:30:35 -06:00 committed by GitHub
parent eb10952c67
commit 9526a4af9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 98 additions and 15 deletions

View File

@ -3,7 +3,7 @@ CLASS net/minecraft/class_5459
COMMENT Finds the largest rectangle within a histogram, where the vertical bars each have
COMMENT width 1 and height specified in {@code heights}.
COMMENT
COMMENT @implNote This implementation is a {@linkplain IntArrayList stack} problem. The
COMMENT @implNote This implementation solves the problem using a stack. The
COMMENT stack maintains a collection of height limits of rectangles that may grow as the
COMMENT array iteration continues. When a new height is encountered, each position {@code p}
COMMENT in the stack would be popped if the rectangle with height limit at position {@code
@ -16,7 +16,8 @@ CLASS net/minecraft/class_5459
COMMENT
COMMENT @return the base of the rectangle as an inclusive range and the height of the
COMMENT rectangle packed in a pair
COMMENT @see https://leetcode.com/problems/largest-rectangle-in-histogram
COMMENT @see <a href="https://leetcode.com/problems/largest-rectangle-in-histogram">Largest
COMMENT Rectangle in Histogram - LeetCode</a>
ARG 0 heights
COMMENT the heights of bars in the histogram
CLASS class_5461 IntBounds

View File

@ -257,7 +257,7 @@ CLASS net/minecraft/class_1297 net/minecraft/entity/Entity
ARG 1 packet
METHOD method_31472 discard ()V
METHOD method_31473 attemptTickInVoid ()V
COMMENT Calls {@link #tickInVoid()} when the entity is 64 blocks below the world's {@linkplain net.minecraft.world.HeightLimitView#getBottomSectionLimit() minimum Y position}.
COMMENT Calls {@link #tickInVoid()} when the entity is 64 blocks below the world's {@linkplain net.minecraft.world.HeightLimitView#getBottomY() minimum Y position}.
METHOD method_31476 getChunkPos ()Lnet/minecraft/class_1923;
METHOD method_31477 getBlockX ()I
METHOD method_31478 getBlockY ()I
@ -629,7 +629,7 @@ CLASS net/minecraft/class_1297 net/minecraft/entity/Entity
METHOD method_5822 canUsePortals ()Z
METHOD method_5824 getRenderDistanceMultiplier ()D
METHOD method_5825 tickInVoid ()V
COMMENT Called when the entity is 64 blocks below the world's {@linkplain net.minecraft.world.HeightLimitView#getBottomSectionLimit() minimum Y position}.
COMMENT Called when the entity is 64 blocks below the world's {@linkplain net.minecraft.world.HeightLimitView#getBottomY() minimum Y position}.
COMMENT
COMMENT <p>{@linkplain LivingEntity Living entities} use this to deal {@linkplain net.minecraft.entity.damage.DamageSource#OUT_OF_WORLD out of world damage}.
METHOD method_5826 setUuid (Ljava/util/UUID;)V

View File

@ -194,7 +194,7 @@ CLASS net/minecraft/class_3218 net/minecraft/server/world/ServerWorld
ARG 1 vibration
METHOD method_32818 (Lnet/minecraft/class_2338;Lnet/minecraft/class_5747;Lnet/minecraft/class_3222;)V
ARG 3 player
METHOD method_32819 getHeightLimit ()I
METHOD method_32819 getLogicalHeight ()I
METHOD method_33142 getPlayersSleepingPercentage (Z)F
ARG 1 longEnough
METHOD method_33143 handleSleeping ()V

View File

@ -6,6 +6,8 @@ CLASS net/minecraft/class_4076 net/minecraft/util/math/ChunkSectionPos
METHOD method_18674 getSectionX ()I
METHOD method_18675 getSectionCoord (I)I
COMMENT Converts a world coordinate to the corresponding chunk-section coordinate.
COMMENT
COMMENT @implNote This implementation returns {@code coord / 16}.
ARG 0 coord
METHOD method_18676 from (III)Lnet/minecraft/class_4076;
COMMENT Creates a chunk section position from its x-, y- and z-coordinates.

View File

@ -2,13 +2,23 @@ CLASS net/minecraft/class_1922 net/minecraft/world/BlockView
COMMENT Represents a scoped, read-only view of block states, fluid states and block entities.
METHOD method_17742 raycast (Lnet/minecraft/class_3959;)Lnet/minecraft/class_3965;
ARG 1 context
METHOD method_17743 (Lnet/minecraft/class_3959;Lnet/minecraft/class_2338;)Lnet/minecraft/class_3965;
ARG 1 context
ARG 2 pos
METHOD method_17744 raycast (Lnet/minecraft/class_243;Lnet/minecraft/class_243;Ljava/lang/Object;Ljava/util/function/BiFunction;Ljava/util/function/Function;)Ljava/lang/Object;
ARG 0 start
ARG 1 end
ARG 2 context
ARG 3 blockHitFactory
ARG 4 missFactory
METHOD method_17745 raycastBlock (Lnet/minecraft/class_243;Lnet/minecraft/class_243;Lnet/minecraft/class_2338;Lnet/minecraft/class_265;Lnet/minecraft/class_2680;)Lnet/minecraft/class_3965;
ARG 1 start
ARG 2 end
ARG 3 pos
ARG 4 shape
ARG 5 state
METHOD method_17746 (Lnet/minecraft/class_3959;)Lnet/minecraft/class_3965;
ARG 0 context
METHOD method_29546 getStatesInBox (Lnet/minecraft/class_238;)Ljava/util/stream/Stream;
ARG 1 box
METHOD method_30346 getDismountHeight (Lnet/minecraft/class_265;Ljava/util/function/Supplier;)D
@ -18,6 +28,11 @@ CLASS net/minecraft/class_1922 net/minecraft/world/BlockView
ARG 1 pos
METHOD method_32880 raycast (Lnet/minecraft/class_5702;)Lnet/minecraft/class_3965;
ARG 1 context
METHOD method_32881 (Lnet/minecraft/class_5702;Lnet/minecraft/class_2338;)Lnet/minecraft/class_3965;
ARG 1 context
ARG 2 pos
METHOD method_32882 (Lnet/minecraft/class_5702;)Lnet/minecraft/class_3965;
ARG 0 context
METHOD method_8315 getMaxLightLevel ()I
METHOD method_8316 getFluidState (Lnet/minecraft/class_2338;)Lnet/minecraft/class_3610;
ARG 1 pos

View File

@ -1,17 +1,82 @@
CLASS net/minecraft/class_5539 net/minecraft/world/HeightLimitView
METHOD method_31597 getTopSectionLimit ()I
METHOD method_31600 getTopHeightLimit ()I
COMMENT A view with a height limit specification.
METHOD method_31597 getTopSectionCoord ()I
COMMENT Returns the top section coordinate, exclusive, of this view.
COMMENT
COMMENT @implNote This implementation passes the {@linkplain #getTopY() top Y}
COMMENT through {@link net.minecraft.util.math.ChunkSectionPos#getSectionCoord(int)}.
COMMENT
COMMENT @return the top section coordinate
COMMENT @see #getBottomSectionCoord()
COMMENT @see #getTopY()
METHOD method_31600 getTopY ()I
COMMENT Returns the top Y level, or height, exclusive, of this view.
COMMENT
COMMENT @implNote This implementation sums up the bottom Y and the height.
COMMENT @see #getBottomY()
COMMENT @see #getHeight()
METHOD method_31601 isOutOfHeightLimit (I)Z
COMMENT Checks if {@code y} is out of the height limit of this view.
COMMENT
COMMENT <p>{@code y} is out of bounds if it's lower than the {@linkplain #getBottomY
COMMENT bottom} or higher than or equal to the {@linkplain #getTopY() top}.
COMMENT
COMMENT @return {@code true} if {@code y} is out of bounds, {@code false} otherwise.
ARG 1 y
COMMENT the Y level to check
METHOD method_31602 getSectionIndex (I)I
COMMENT Returns a zero-based section index to which the {@code y} level belongs.
COMMENT
COMMENT @return a zero-based index
ARG 1 y
METHOD method_31603 getSectionIndexFromSection (I)I
ARG 1 section
METHOD method_31604 getSection (I)I
ARG 1 sectionIndex
METHOD method_31605 getSectionCount ()I
METHOD method_31603 sectionCoordToIndex (I)I
COMMENT Converts a section coordinate to a zero-based section index.
COMMENT
COMMENT @return a zero-based index
COMMENT @see #sectionIndexToCoord(int) the inverse operation <code>sectionIndexToCoord</code>
ARG 1 coord
COMMENT the section coordinate
METHOD method_31604 sectionIndexToCoord (I)I
COMMENT Converts a zero-based section index to a section coordinate.
COMMENT
COMMENT @return a section coordinate
COMMENT @see #sectionCoordToIndex(int) the inverse operation <code>sectionCoordToIndex</code>
ARG 1 index
COMMENT the zero-based section index
METHOD method_31605 getHeight ()I
COMMENT Returns the difference in the {@linkplain #getBottomY() minimum} and
COMMENT {@linkplain #getTopY() maximum} height.
COMMENT
COMMENT <p>This is the number of blocks that can be modified in any vertical column
COMMENT within the view, or the vertical size, in blocks, of the view.
COMMENT
COMMENT @return the difference in the minimum and maximum height
COMMENT @see #getBottomY()
COMMENT @see #getTopY()
METHOD method_31606 isOutOfHeightLimit (Lnet/minecraft/class_2338;)Z
COMMENT Checks if {@code pos} is out of the height limit of this view.
COMMENT
COMMENT @return {@code true} if {@code pos} is out of bounds, {@code false} otherwise.
COMMENT @see #isOutOfHeightLimit(int)
ARG 1 pos
METHOD method_31607 getBottomSectionLimit ()I
METHOD method_32890 getSections ()I
METHOD method_32891 getMinimumSection ()I
COMMENT the position to check
METHOD method_31607 getBottomY ()I
COMMENT Returns the bottom Y level, or height, inclusive, of this view.
COMMENT
COMMENT @see #getTopY()
COMMENT @see #getHeight()
METHOD method_32890 countVerticalSections ()I
COMMENT Returns the number of sections, vertically, within this view.
COMMENT
COMMENT @return the number of sections
COMMENT @see #getTopSectionCoord()
COMMENT @see #getBottomSectionCoord()
METHOD method_32891 getBottomSectionCoord ()I
COMMENT Returns the bottom section coordinate, inclusive, of this view.
COMMENT
COMMENT @implNote This implementation passes the {@linkplain #getBottomY() bottom Y}
COMMENT through {@link net.minecraft.util.math.ChunkSectionPos#getSectionCoord(int)}.
COMMENT
COMMENT @return the bottom section coordinate
COMMENT @see #getTopSectionCoord()
COMMENT @see #getBottomY()