From f32ff77fb14af43ac354b8764fb01c62d8749423 Mon Sep 17 00:00:00 2001 From: haykam821 <24855774+haykam821@users.noreply.github.com> Date: Wed, 5 May 2021 07:57:42 -0400 Subject: [PATCH] Improve documentation for teleport targets (#2379) --- mappings/net/minecraft/entity/Entity.mapping | 3 +++ mappings/net/minecraft/world/TeleportTarget.mapping | 2 ++ mappings/net/minecraft/world/dimension/AreaHelper.mapping | 3 +++ 3 files changed, 8 insertions(+) diff --git a/mappings/net/minecraft/entity/Entity.mapping b/mappings/net/minecraft/entity/Entity.mapping index 57e730898a..3ce8119191 100644 --- a/mappings/net/minecraft/entity/Entity.mapping +++ b/mappings/net/minecraft/entity/Entity.mapping @@ -262,6 +262,9 @@ CLASS net/minecraft/class_1297 net/minecraft/entity/Entity METHOD method_30229 resetNetherPortalCooldown ()V METHOD method_30230 hasNetherPortalCooldown ()Z METHOD method_30329 getTeleportTarget (Lnet/minecraft/class_3218;)Lnet/minecraft/class_5454; + COMMENT Determines a {@link TeleportTarget} for the entity + COMMENT based on its current and destination worlds, plus + COMMENT any portals that may be present. ARG 1 destination METHOD method_30330 getPortalRect (Lnet/minecraft/class_3218;Lnet/minecraft/class_2338;Z)Ljava/util/Optional; ARG 1 destWorld diff --git a/mappings/net/minecraft/world/TeleportTarget.mapping b/mappings/net/minecraft/world/TeleportTarget.mapping index b13a89d16f..ca7dbf51ed 100644 --- a/mappings/net/minecraft/world/TeleportTarget.mapping +++ b/mappings/net/minecraft/world/TeleportTarget.mapping @@ -1,4 +1,6 @@ CLASS net/minecraft/class_5454 net/minecraft/world/TeleportTarget + COMMENT Represents the position that an entity takes after being + COMMENT {@linkplain net.minecraft.entity.Entity#moveToWorld moved between worlds}. FIELD field_25879 position Lnet/minecraft/class_243; FIELD field_25880 velocity Lnet/minecraft/class_243; FIELD field_25881 yaw F diff --git a/mappings/net/minecraft/world/dimension/AreaHelper.mapping b/mappings/net/minecraft/world/dimension/AreaHelper.mapping index b606e6ce90..ae454f6dca 100644 --- a/mappings/net/minecraft/world/dimension/AreaHelper.mapping +++ b/mappings/net/minecraft/world/dimension/AreaHelper.mapping @@ -17,6 +17,9 @@ CLASS net/minecraft/class_2424 net/minecraft/world/dimension/AreaHelper METHOD method_10362 wasAlreadyValid ()Z METHOD method_10363 createPortal ()V METHOD method_30484 getNetherTeleportTarget (Lnet/minecraft/class_3218;Lnet/minecraft/class_5459$class_5460;Lnet/minecraft/class_2350$class_2351;Lnet/minecraft/class_243;Lnet/minecraft/class_4048;Lnet/minecraft/class_243;FF)Lnet/minecraft/class_5454; + COMMENT Determines a {@link TeleportTarget} based on a specific portal. + COMMENT + COMMENT

The offset, velocity, and angle are modified based on the portal's axis. ARG 0 destination ARG 1 portalRect ARG 2 portalAxis