* Minor fixes
- Fix casing in the name of GlImportProcessor, fixes#3488
- Use full word "playerInventory" instead of "inv" in
ScreenHandlerFactory for clarity. The conventions instruct to avoid
unnecessary abbreviations and this name could be mistaken for the
inventory of the block that the screen handler is for.
- BlockRenderManager.renderBlockAsEntity: vertexConsumer ->
vertexConsumers since it's a VertexConsumerProvider
* Rename stack parameter in block breaking methods to tool
Closes#2988. "Tool" more clearly shows what stack the param is supposed
to be.
* Block/AbstractBlockState.isTranslucent -> isTransparent
It's true for any block with a non-full shape as well as
vines, (colourless) glass and plants - none of these are translucent.
* 23w07a stuff
Got a bit carried away...
Some names aren't ideal, and there's still more that could be done, so feedback is appreciated
* More + suggestions
* 48a things
* stuff
* Apply suggestions from code review
Co-authored-by: haykam821 <24855774+haykam821@users.noreply.github.com>
* just to get checks running again
* Revert "just to get checks running again"
This reverts commit 509ab81d80.
Co-authored-by: haykam821 <24855774+haykam821@users.noreply.github.com>
* Update all the models fields that come from Mojang's json code
* Unswap tailAngle and spikeExtension fields
* Fill in missing names in MathHelper
* Apply suggestions from code review
Co-authored-by: YanisBft <doublecraft.official@gmail.com>
* More code review fixes
Co-authored-by: YanisBft <doublecraft.official@gmail.com>
* Things
* Update AbstractCauldronBlock.mapping
* a few more things
* Create EntityModelLayers.mapping
* Update MinecraftVersion.mapping
* Update Oxidizable.mapping
* part.render(matrix, vertices, light, overlay, red, green, blue, alpha)
* Fixed bad names
* Determined by the call to part.render(matrix, vertices, light, overlay)
which delegates to part.render(matrix, vertices, light, overlay, 1, 1, 1, 1)
* Now we extrapolate to everything that calls part.render(matrix, vertices, light, overlay)
Meanhile VertexConsumerProvider is
* Now we extrapolate to everything that cals pars.render(matrix, vertices, light, overlay, red, green, blue, alpha)
* This is not a render method! It sets the yaw and pitch on the skull
* Now we extrapolate to things that call mode.render(matrix, vertices, light, overlay, red, green, blue, alpha)
Not much to change there though
* These are known from EntityRenderDispatcher
* render calls renderLabelIfPresent
* Now we're looking at things which call EntityRenderDispatcher.render(entity, x, y, z, yaw, matrix, provider, light)
* In ClientPlayNetworkHandler.onItemPickupAnimation the second entity is gotten from packet.getCollectorEntityId and defaulted to the player if null. The first entity is an item entity or an experience orb entity
* Going back to EntityRenderDispatcher, we can see the code for rendering shadows was moved here from the renderer itself
if (this.gameOptions.entityShadows && this.renderShadows && entityRenderer14.shadowRadius > 0.0f && !entity.isInvisible()) {
double double22 = this.getSquaredDistanceToCamera(entity.getX(), entity.getY(), entity.getZ());
float float24 = (float)((1.0 - double22 / 256.0) * entityRenderer14.field_4672);
if (float24 > 0.0f) {
renderShadow(matrix, provider, entity, float24, tickDelta, this.world, entityRenderer14.shadowRadius);
}
}
* The last parameter is shadow radius, but to be sure we check, nd indeed it is reduced when the rendered entity is a baby
private static void renderShadow(MatrixStack matrix, VertexConsumerProvider provider, Entity entity, float float4, float tickDelta, WorldView world, float radius) {
float float8 = radius;
if (entity instanceof MobEntity) {
if (((MobEntity)entity).isBaby()) {
float8 *= 0.5f;
}
}
* float4 was a myster, but it's just passed down as-is and used to determine the opacity of the shadow!
float float16 = (float)((opacity - (y - pos.getY()) / 2.0) * 0.5 * world.getBrightness(pos));
if (float16 >= 0.0f) {
* Forgot this one
* This is all low-hanging fruit.
* EntityRenderDispatcher.shouldRender(entity, frustrum, x, y, z)
-> EntityRenderer.isVisible(entity, frustrum, x, y, z)
-> Entity.shouldRenderFrom(x, y, z)
@Environment(EnvType.CLIENT)
public boolean shouldRenderFrom(double x, double y, double z) {
double double8 = this.getX() - x;
double double10 = this.getY() - y;
double double12 = this.getZ() - z;
double double14 = double8 * double8 + double10 * double10 + double12 * double12;
return this.shouldRenderAtDistance(double14);
}
* More things we know
* This is set by calling entity.getLeaningPitch
* This is only overriden by CreeperEntityRenderer and returns a float computed from the fuse time.
The value is then passed to getOverlay where it's passed to OverlayTexture.getU(animationCounter).
This causes the creeper to flash white when active. The same method,
interestingly, will use the V to create the hurt/death overlay
OverlayTexture.packUv(
OverlayTexture.getU(animationCounter),
OverlayTexture.getV(entity.hurtTime > 0 || entity.deathTime > 0)
)
* The final patches
* xrayEnabled -> isGlowing
* Commit suggestions/name changes I missed during rebase
Co-Authored-By: Juuxel <6596629+Juuxel@users.noreply.github.com>
* Fix typos
* yaw -> tickDelta
Co-Authored-By: liach <7806504+liach@users.noreply.github.com>
* provider -> vertexConsumers
Co-Authored-By: liach <7806504+liach@users.noreply.github.com>
* matrix -> matrices
Co-Authored-By: liach <7806504+liach@users.noreply.github.com>
* Fixed some encorrect names
* entry -> matrices
* textureU/V -> u/v
* isBanner -> isBannerBlock
* frustrum -> frustum
Co-Authored-By: Gegy <gegy1000@gmail.com>
* Fix broken/changed mappings for 20w10a
* grammar
Co-Authored-By: liach <7806504+liach@users.noreply.github.com>
* Update mappings/net/minecraft/client/particle/ItemPickupParticle.mapping
Co-Authored-By: liach <7806504+liach@users.noreply.github.com>
Co-authored-by: Juuxel <6596629+Juuxel@users.noreply.github.com>
Co-authored-by: liach <7806504+liach@users.noreply.github.com>
Co-authored-by: Gegy <gegy1000@gmail.com>
* Some stuff for 1.15 pre 1
wood type or sign type? it is only used by signs.
Signed-off-by: liach <liach@users.noreply.github.com>
* A few more stuff
Signed-off-by: liach <liach@users.noreply.github.com>
* bits of stuff
Signed-off-by: liach <liach@users.noreply.github.com>
* Call it a sign type
Signed-off-by: liach <liach@users.noreply.github.com>
* More stuff and refactors per suggestion
* More bits
Signed-off-by: liach <liach@users.noreply.github.com>
* Missed the one i need to map
Signed-off-by: liach <liach@users.noreply.github.com>
* You like dual better
Signed-off-by: liach <liach@users.noreply.github.com>
* Update mappings/net/minecraft/client/texture/SpriteAtlasTexture.mapping
* 😓
Signed-off-by: liach <liach@users.noreply.github.com>
* Some pre2 stuff as well
* Refactor rendering
* Revert #929 and map more things
* Fixes by liach
* Revert bufferBuilder -> buffer in fields too
* Fixes
* Update mappings/net/minecraft/util/MessageQueue.mapping
Co-Authored-By: liach <7806504+liach@users.noreply.github.com>
* Update mappings/net/minecraft/util/MessageQueue.mapping
Co-Authored-By: liach <7806504+liach@users.noreply.github.com>
* Suggestions by Player
* Fix some debug renderer names
* More mappings
* Fix
* Fixes by Player
* Improve BufferBuilderStorage names
* A few mappings
* Suggestions by liach
* Improvements
* Add methods from liach's PR
* make -> get to match others
* get -> create for methods that create tasks
Shnupbups